Store address hierarchy information in attributes instead of channel args.#24167
Merged
markdroth merged 1 commit intogrpc:masterfrom Sep 17, 2020
Merged
Conversation
markdroth
added
the
release notes: no
donnadionne
approved these changes
Sep 17, 2020
markdroth
force-pushed
the
hierarchical_address_attributes
branch
from
fefdf07 to
855a55a
Compare
Member
Author
|
Known issue: #23597 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more appropriate, since the attributes are not part of the key in the subchannel pool and therefore do not affect uniqueness. The address hierarchy information is relevant only to LB policies and should not affect the subchannel identity.