Skip to content

remove --spawn_strategy build option for cfstream_test#24161

Merged
yulin-liang merged 1 commit intogrpc:masterfrom
yulin-liang:fix-cfstream
Sep 17, 2020
Merged

remove --spawn_strategy build option for cfstream_test#24161
yulin-liang merged 1 commit intogrpc:masterfrom
yulin-liang:fix-cfstream

Conversation

@yulin-liang
Copy link
Copy Markdown
Contributor

@yulin-liang yulin-liang commented Sep 15, 2020 •
edited
Loading

Having the --spawn_strategy build option will cause the following build issue with #23533(more info: b/160165400):

ERROR: /Users/jtattermusch/github/grpc/BUILD:3052:1: undeclared inclusion(s) in rule '//:google_api_upbdefs':
this rule is missing dependency declarations for the following files included by 'src/core/ext/upbdefs-generated/google/protobuf/descriptor.upbdefs.c':
  'bazel-out/darwin-fastbuild/bin/external/com_google_protobuf/google/protobuf/descriptor.upbdefs.h'
Target //test/cpp/end2end:cfstream_test failed to build

Looks like removing --spawn_strategy will not affect our current tests.

@yulin-liang yulin-liang added lang/core release notes: no Indicates if PR should not be in release notes kokoro:force-run labels Sep 15, 2020
@yulin-liang yulin-liang marked this pull request as ready for review September 17, 2020 18:45
stanley-cheung
stanley-cheung approved these changes Sep 17, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yulin-liang yulin-liang merged commit 15a287b into grpc:master Sep 17, 2020
@yulin-liang yulin-liang deleted the fix-cfstream branch September 17, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stanley-cheung stanley-cheung stanley-cheung approved these changes

Assignees

@stanley-cheung stanley-cheung

Labels

lang/core release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yulin-liang @stanley-cheung @grpc-kokoro