Move logic for generating service config from XdsClient to xds resolver.#23781
Merged
markdroth merged 1 commit intogrpc:masterfrom Aug 11, 2020
Merged
Move logic for generating service config from XdsClient to xds resolver.#23781markdroth merged 1 commit intogrpc:masterfrom
markdroth merged 1 commit intogrpc:masterfrom
Conversation
markdroth
added
the
release notes: no
donnadionne
approved these changes
Aug 11, 2020
Contributor
donnadionne
left a comment
donnadionne
left a comment
There was a problem hiding this comment.
Looks good to me.
And I will just modify the generating the service config for my feature from this new location.
markdroth
force-pushed
the
xds_client_api
branch
from
9ed4e6f to
107853a
Compare
Member
Author
|
Green! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.