Merged
Conversation
veblush
added
kind/enhancement
lang/core
release notes: no
Contributor
Author
|
grpc_build_artifacts_multiplatform: running |
veblush
force-pushed
the
shutdown
branch
2 times, most recently
from
480a0ed to
00c60c9
Compare
Contributor
Author
Contributor
Author
|
Testing with internal cherry-pick cl/328662650 -> Passed by a couple of deflakes. |
veblush
force-pushed
the
shutdown
branch
2 times, most recently
from
13b4c3a to
46cd3e4
Compare
yang-g
approved these changes
Sep 3, 2020
vjpai
suggested changes
Sep 3, 2020
vjpai
approved these changes
Sep 3, 2020
Contributor
vjpai
left a comment
vjpai
left a comment
There was a problem hiding this comment.
Great, all comments resolved.
This was referenced Sep 8, 2020
veblush
added a commit
that referenced
this pull request
Sep 17, 2020
Fix-forward "Implemented conditional shutdown" (#23710)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes
grpc_shutdownto execute shutdown immediately if it's called not from execution threads, which is free from the dead-lock case where original asyncgrpc_shutdowntried to address. This makes shutdown more deterministic so that unit tests can assume that all gRPC resources including threads are properly deallocated at the end of test. Note thatgrpc_shutdowncan still spawn a detached thread for actual shutdown when the finalgrpc_shutdownis called from the execution thread.Fixes: #23604