PHP: Fix include path for boringssl in windows build#22993
Merged
stanley-cheung merged 2 commits intogrpc:v1.29.xfrom May 20, 2020
Merged
PHP: Fix include path for boringssl in windows build#22993stanley-cheung merged 2 commits intogrpc:v1.29.xfrom
stanley-cheung merged 2 commits intogrpc:v1.29.xfrom
Conversation
stanley-cheung
added
lang/php
release notes: no
Contributor
Author
|
Turns out I also need #22798 (which is only merged to |
apolcyn
approved these changes
May 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same fix as #22274.
Apparently changes in
v1.28.xhasn't been upmerged tomasterbeforev1.29.xbranch is cut, so I need this fix to be applied to thev1.29.xnow, because the same error is showing up in thev1.29.0release for PHP.I will also create another PR for
master(#22994), and will probably do an upmerge tomasterlater.