PHP: fix of a bit of memory leak#22706
Merged
stanley-cheung merged 1 commit intogrpc:masterfrom Apr 20, 2020
Merged
Conversation
HannahShiSFB
changed the title
stanley-cheung
added
kokoro:run
lang/php
release notes: no
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on #19737, addref() was added on user's request, it's a fix of #19721 "Missing addref on ChannelCredentials in Channel constructor causes segfault"
At that time, grpc-php-ext was using php_grpc_zend_hash_del() to delete 3 objects, including "credentials", from args_array, but "credentials" object was used later. After fix, addref(increase ref) and delete(decrease ref) as a pair, made it OK, no memory leak then.
Later on #20249, when the code was modified, php-ext stopped using php_grpc_zend_hash_del() any more. addref() is not needed any more.