Revert "Revert "Introduce CFRunLoop based iomgr""#22687
Merged
Conversation
muxi
added
lang/core
release notes: no
Contributor
Author
|
@guantaol - ready to review. Sorry for the trouble. |
Contributor
Author
|
actually it's not... let me take a look |
muxi
force-pushed
the
revert-22684-revert-22423-objc-poller
branch
from
4b1d4bf to
8bff072
Compare
Contributor
Author
|
Good now. |
guantaol
approved these changes
Apr 20, 2020
Contributor
Author
|
Known failure: #18892 |
This was referenced May 5, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #22684
Breakage cause: grpc_cfstream tests need to be run with CFStream. This PR removes GRPC_CFSTREAM macro for Mac. We will need to enable it with --copt in bazel command.