Add --bootstrap_file to run_xds_tests.py#22566
Merged
ejona86 merged 2 commits intogrpc:masterfrom Apr 3, 2020
Merged
Conversation
This allows using an external bootstrap generator.
ericgribkoff
approved these changes
Apr 3, 2020
ejona86
added a commit
to ejona86/grpc
that referenced
this pull request
Apr 3, 2020
Add --bootstrap_file to run_xds_tests.py
ejona86
added a commit
that referenced
this pull request
Apr 3, 2020
…tstrap-gen Backport #22566 to v1.28 (Add --bootstrap_file to run_xds_tests.py)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows using an external bootstrap generator.
I tested manually with and without the flag and tested passing and injected errors in both cases (obviously kokoro will continue without the flag).