Add param to echo captured client output in logs#22564
Merged
ericgribkoff merged 1 commit intogrpc:masterfrom Apr 3, 2020
Merged
Add param to echo captured client output in logs#22564ericgribkoff merged 1 commit intogrpc:masterfrom
ericgribkoff merged 1 commit intogrpc:masterfrom
Conversation
ericgribkoff
added
lang/other
release notes: no
gnossen
approved these changes
Apr 3, 2020
Contributor
gnossen
left a comment
gnossen
left a comment
There was a problem hiding this comment.
My only concern would be if there weren't timestamps in the client logs. But I believe all clients currently do.
ericgribkoff
added a commit
to ericgribkoff/grpc
that referenced
this pull request
Apr 3, 2020
Add param to echo captured client output in logs
ericgribkoff
added a commit
that referenced
this pull request
Apr 3, 2020
Merge pull request #22564 from ericgribkoff/inline_logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our internal staging tests cannot (easily) pick up the nicely outputted files produced by
report_utils.render_junit_xml_report. This is a temporary-ish workaround for that to allow us to at least see the client output in any staging failures.Also considered an argument to just disable capturing the output from the
subprocess.Popencall and including them inline in the script's output, but went with this approach as it seems helpful to still have the separation (albeit still in stdout, but at least not jumbled together) betweenrun_xds_test.pylogs and the client logs. If that seems preferable let me know and I'll switch to that approach.