Avoid using hardcoded test credentials#22542
Merged
jiangtaoli2016 merged 1 commit intogrpc:masterfrom Apr 3, 2020
Merged
Conversation
jiangtaoli2016
added
release notes: no
jiangtaoli2016
force-pushed
the
deprecate_hardcoded_test_keys
branch
from
695359f to
1680d41
Compare
jiangtaoli2016
changed the title
Author
|
ping @ZhenLian @jtattermusch |
ZhenLian
approved these changes
Apr 3, 2020
Contributor
ZhenLian
left a comment
ZhenLian
left a comment
There was a problem hiding this comment.
LGTM! Thanks for making the changes @jiangtaoli2016 ! I will do the rest for all the other call sites and deprecate the hardcoded test credentials.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just deprecates hardcoded test_signed_client_key/cert.
More to go.