Skip to content

PHP: Fix include path for boringssl in windows build#22274

Merged
stanley-cheung merged 1 commit intogrpc:v1.28.xfrom
stanley-cheung:php-fix-boringssl-include
Mar 11, 2020
Merged

PHP: Fix include path for boringssl in windows build#22274
stanley-cheung merged 1 commit intogrpc:v1.28.xfrom
stanley-cheung:php-fix-boringssl-include

Conversation

@stanley-cheung
Copy link
Copy Markdown
Contributor

Fixes #22273

Probably because in #21833, we fixed templates/config.m4.template, but forgot templates/config.w32.template.

@stanley-cheung stanley-cheung added lang/php release notes: no Indicates if PR should not be in release notes labels Mar 9, 2020
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@stanley-cheung stanley-cheung merged commit 5a03aed into grpc:v1.28.x Mar 11, 2020
@stanley-cheung stanley-cheung deleted the php-fix-boringssl-include branch March 16, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang/php release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants