Send a scheme of http or https as appropriate, rather than grpc.#22
Merged
ctiller merged 2 commits intogrpc:masterfrom Jan 14, 2015
dklempner:http_scheme
Merged
Send a scheme of http or https as appropriate, rather than grpc.#22ctiller merged 2 commits intogrpc:masterfrom dklempner:http_scheme
ctiller merged 2 commits intogrpc:masterfrom
dklempner:http_scheme
Conversation
This requires additional logic to determine whether to send http or https. This change assumes a default of http, and plumbs down https through a synthesized channel arg when using the ssl transport.
Contributor
There was a problem hiding this comment.
Recommend returning const char *
1. scheme_from_args should return const char* 2. Rename grpc.scheme arg to grpc.http2_scheme, and define a macro for it.
ctiller
added a commit
that referenced
this pull request
Jan 14, 2015
Send a scheme of http or https as appropriate, rather than grpc.
Closed
stanley-cheung
referenced
this pull request
in stanley-cheung/grpc
Aug 27, 2015
…orld_code_and_docs Grpc samples update java helloworld code and docs
This was referenced Oct 6, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires additional logic to determine whether to send http or
https. This change assumes a default of http, and plumbs down https
through a synthesized channel arg when using the ssl transport.