Skip to content

Use absl/synchronization in gRPC Core#21606

Closed
veblush wants to merge 1 commit intogrpc:masterfrom
veblush:absl-lock
Closed

Use absl/synchronization in gRPC Core#21606
veblush wants to merge 1 commit intogrpc:masterfrom
veblush:absl-lock

Conversation

@veblush
Copy link
Copy Markdown
Contributor

@veblush veblush commented Jan 7, 2020

Let's try it out.

grpc_build_artifacts_multiplatform: failed due to ruby (2nd)
grpc_build_artifacts_extra_release: passed

Remaining issues:

  • distribtest.ruby_linux_x64_centos6_version_unspecified failed due to clock_gettime@GLIBC_2.17 symbol from grpc_c.so.
    • This is because clock_gettime moved from librt to libc since 2.17. (bug, manual)
  • Unit test failures
    • Bazel RBE MSAN 252 new failures. (test)
    • Bazel RBE UBSAN 1 new failures. (//test/cpp/naming:resolver_component_tests_runner_invoker_unsecure@poller=epoll1)
    • Bazel RBE Windows Debug C/C++ 1 new failures. (//test/cpp/util:slice_test)

@veblush veblush added lang/core release notes: no Indicates if PR should not be in release notes labels Jan 7, 2020
@veblush veblush force-pushed the absl-lock branch 4 times, most recently from e5cffd9 to e1a73f5 Compare January 8, 2020 22:49
@veblush
Copy link
Copy Markdown
Contributor Author

veblush commented Jan 9, 2020

Trying to replace grpc_shutdown with grpc_shutdown_blocking turned out to be effective in fixing many test breakages. Let's fix the problem separately. Following is the test result:

Bazel RBE Debug C/C++

  • exited with error code 139 or 134
    //test/core/end2end:h2_http_proxy_nosec_test@no_error_on_hotpath@poller=epoll1
    //test/cpp/end2end:xds_end2end_test@poller=epollex
    //test/cpp/end2end:xds_end2end_test@poller=poll

Bazel RBE Opt C/C++

  • exited with error code 139, 132, or 134
    //test/cpp/end2end:client_lb_end2end_test@poller=epollex
    //test/cpp/end2end:grpclb_end2end_test@poller=poll
    //test/cpp/end2end:xds_end2end_test@poller=epoll1
    //test/cpp/end2end:xds_end2end_test@poller=poll
    //test/core/end2end:h2_ssl_nosec_test@retry_server_pushback_disabled@poller=poll
    //test/cpp/end2end:grpclb_end2end_test@poller=epollex
    //test/cpp/end2end:xds_end2end_test@poller=epollex

Bazel RBE ASAN C/C++

  • tool failed

Bazel RBE TSAN C/C++

  • exited with error code 66
    //test/core/end2end:h2_full+pipe_nosec_test@max_connection_idle@poller=epoll1
    //test/core/handshake:client_ssl@poller=epollex
    //test/cpp/client:client_channel_stress_test@poller=epollex
    //test/cpp/end2end:client_lb_end2end_test@poller=epollex
    //test/cpp/end2end:xds_end2end_test@poller=epoll1
    //test/cpp/end2end:xds_end2end_test@poller=epollex
    //test/cpp/end2end:xds_end2end_test@poller=poll

@veblush veblush force-pushed the absl-lock branch 3 times, most recently from aafcf2a to ac4abf4 Compare January 29, 2020 03:51
@veblush veblush force-pushed the absl-lock branch 2 times, most recently from cf94379 to 4fc5458 Compare February 12, 2020 18:31
@veblush veblush force-pushed the absl-lock branch 3 times, most recently from 37a4094 to f3e563a Compare February 26, 2020 18:58
@stale
Copy link
Copy Markdown

stale bot commented May 6, 2020

This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 30 days. It will be closed automatically if no further update occurs in 7 day. Thank you for your contributions!

@stale stale bot closed this May 13, 2020
@veblush veblush mentioned this pull request Jul 1, 2020
@veblush
Copy link
Copy Markdown
Contributor Author

veblush commented Jul 18, 2020

Continuing by #23372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

disposition/stale lang/core release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants