Unify boringssl submodules and use non-developer boringssl cmake build#21527
Unify boringssl submodules and use non-developer boringssl cmake build#21527jtattermusch merged 26 commits intogrpc:masterfrom
Conversation
6fa8590 to
dae922c
Compare
https://source.cloud.google.com/results/invocations/bead21ee-4f3a-4e2c-a3b8-fa3a17111027/targets/%2F%2Ftest%2Fcore%2Fend2end:h2_oauth2_test@filter_context@poller%3Depollex/log |
|
@muxi can you please help fixing the grpc/templates/src/objective-c/BoringSSL-GRPC.podspec.template? The change in this PR is that instead of |
|
@muxi looks like there's still some errors: Errorhttps://source.cloud.google.com/results/invocations/772a7f41-c3a9-4ed9-91bc-bcc9fe7d2630/targets/github%2Fgrpc%2Frun_tests%2Fobjc_macos_opt_native%2Fios-buildtest-example-sample-frameworks/tests |
|
Adhoc run of boringssl_at_head build is passing: https://source.cloud.google.com/results/invocations/a0f46bd7-93fd-478c-90bc-80076dccc372/log |
0762555 to
cb800db
Compare
|
This is now ready to review. There might be little bit of cleanup remaining, but that can be done incrementally as a followup (this PR is already complicated enough). |
|
FYI @gnossen @nicolasnoble I will also need owner's approval. |
|
If there are any more comments, I can address them as a followup. |
Reintroduce #21527 (boringssl submodule unification)
Revert "Reintroduce #21527 (boringssl submodule unification)"
…on)"" This reverts commit cca8920.
Reintroduce #21527 (boringssl submodule unification - take two)
Main parts of this PR:
A bit more background on boringssl's "master" vs "master-with-bazel" branches (might be useful when reviewing).
both contain the same code, but "master-with-bazel" has exactly the same files as "master" but all the sources are moved under
/srcand in the repository root there are some pre-generated assembly files used by the CMake and bazel builds. The "master-with-bazel" branch is updated by boringssl team's bot every time a commit is added to "master".(also see https://github.com/google/boringssl/blob/master/INCORPORATING.md#bazel)
TODOs: