Skip to content

Delete unused grpclb-in-dns interop test suite#21439

Merged
jtattermusch merged 1 commit intogrpc:masterfrom
apolcyn:revert_grpclb_in_dns_interop
Dec 9, 2020
Merged

Delete unused grpclb-in-dns interop test suite#21439
jtattermusch merged 1 commit intogrpc:masterfrom
apolcyn:revert_grpclb_in_dns_interop

Conversation

@apolcyn
Copy link
Copy Markdown
Contributor

@apolcyn apolcyn commented Dec 10, 2019

This test suite caught some issues when first introduced in #16727, but for a long time now we've had a larger set of more realistic integration tests that exercise grpclb (they live outside of this repo), and my thinking is that attention is better spent on those tests then here.

cc @ejona86 @zhangkun83

@apolcyn apolcyn added lang/all wrapped languages area/test release notes: no Indicates if PR should not be in release notes labels Dec 10, 2019
jtattermusch
jtattermusch approved these changes Dec 13, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@stale
Copy link
Copy Markdown

stale bot commented May 6, 2020

This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 30 days. It will be closed automatically if no further update occurs in 7 day. Thank you for your contributions!

@jtattermusch
Copy link
Copy Markdown
Contributor

jtattermusch commented May 6, 2020

should we merge?

@stale stale bot removed the disposition/stale label May 6, 2020
@stale
Copy link
Copy Markdown

stale bot commented Aug 4, 2020

This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 30 days. It will be closed automatically if no further update occurs in 7 day. Thank you for your contributions!

@jtattermusch
Copy link
Copy Markdown
Contributor

jtattermusch commented Aug 5, 2020

Let's revive or close.
Because this is deleting unused code I'd be in favor of reviving it to get things cleaned up.

@stale stale bot removed the disposition/stale label Aug 5, 2020
@stale
Copy link
Copy Markdown

stale bot commented Dec 8, 2020

This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 30 days. It will be closed automatically if no further update occurs in 7 day. Thank you for your contributions!

@stale stale bot removed the disposition/stale label Dec 8, 2020
@jtattermusch
Copy link
Copy Markdown
Contributor

jtattermusch commented Dec 8, 2020

Let's update the PR and get this cleaned up.

@jtattermusch jtattermusch force-pushed the revert_grpclb_in_dns_interop branch from b0b377e to 70f3a25 Compare December 8, 2020 16:03
@jtattermusch
Copy link
Copy Markdown
Contributor

jtattermusch commented Dec 8, 2020

I rebased the PR, resolved conflicts and will merge on green tests.

@jtattermusch jtattermusch merged commit 600dd1b into grpc:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolasnoble nicolasnoble Awaiting requested review from nicolasnoble

1 more reviewer

@jtattermusch jtattermusch jtattermusch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jtattermusch jtattermusch

Labels

area/test disposition/never stale lang/all wrapped languages release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@apolcyn @jtattermusch