Reuse ports in xds_end2end_test#20787
Merged
markdroth merged 2 commits intogrpc:masterfrom Oct 24, 2019
Merged
Conversation
AspirinSJL
approved these changes
Oct 24, 2019
Member
Author
Member
|
Please make sure this passes internally :) |
Member
Author
|
I did; it works fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit reverts #20772. The second commit adds a new mechanism for reusing ports between tests, so that the maximum number of ports used is now no greater than is needed for any one test.