Skip to content

Reuse ports in xds_end2end_test#20787

Merged
markdroth merged 2 commits intogrpc:masterfrom
markdroth:xds_test_port_fix
Oct 24, 2019
Merged

Reuse ports in xds_end2end_test#20787
markdroth merged 2 commits intogrpc:masterfrom
markdroth:xds_test_port_fix

Conversation

@markdroth
Copy link
Copy Markdown
Member

The first commit reverts #20772. The second commit adds a new mechanism for reusing ports between tests, so that the maximum number of ports used is now no greater than is needed for any one test.

@markdroth markdroth added the release notes: no Indicates if PR should not be in release notes label Oct 24, 2019
@markdroth markdroth requested a review from AspirinSJL October 24, 2019 18:00
@markdroth
Copy link
Copy Markdown
Member Author

Known issues: #20792 #20759

@markdroth markdroth merged commit 2273cae into grpc:master Oct 24, 2019
@markdroth markdroth deleted the xds_test_port_fix branch October 24, 2019 22:00
@yashykt
Copy link
Copy Markdown
Member

yashykt commented Oct 24, 2019

Please make sure this passes internally :)

@markdroth
Copy link
Copy Markdown
Member Author

I did; it works fine.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants