Skip to content

Comment out the test suites that has oversize port pool#20772

Merged
nanahpang merged 4 commits intogrpc:masterfrom
nanahpang:fix-xds-test-suite
Oct 24, 2019
Merged

Comment out the test suites that has oversize port pool#20772
nanahpang merged 4 commits intogrpc:masterfrom
nanahpang:fix-xds-test-suite

Conversation

@nanahpang
Copy link
Copy Markdown
Contributor

@nanahpang nanahpang commented Oct 23, 2019

This PR comments out the test suites that exceed the port limitation in #20476. I cannot revert that PR automatically, because of other changes are merged. So comment out the test suites that are failing. Wait for @markdroth to fix them later.

@nanahpang nanahpang added the release notes: no Indicates if PR should not be in release notes label Oct 23, 2019
@nanahpang nanahpang requested a review from AspirinSJL October 23, 2019 22:37
Copy link
Copy Markdown
Contributor

@AspirinSJL AspirinSJL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment.

@nanahpang
Copy link
Copy Markdown
Contributor Author

Please add a comment.

Done. And I also update the description.

@nanahpang nanahpang merged commit 100006d into grpc:master Oct 24, 2019
markdroth added a commit to markdroth/grpc that referenced this pull request Oct 24, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants