Start running bazel C/C++ tests on mac by jtattermusch · Pull Request #20510 · grpc/grpc

jtattermusch · 2019-10-07T12:31:45Z

Setup continuous C/C++ test under bazel.
The tests are setup very similar to linux/windows RBE tests, with the exception that Foundry doesn't support Mac executors, so the tests are still built and run locally (but the test results are uploaded to result store).

I will enable the tests on PRs once the test results on master are stable.

There is also a number of fixes to the bazel tests on mac:

added grpc_init() and grpc_shutdown() to some tests, because due to grpc Mac bazel build fails because of thread-local, but make passes bazelbuild/bazel#4341 we are using GPR_PTHREAD_TLS on mac, which requires initializing thread local variables before using them.
under bazel, GRPC_CFSTREAM is enabled and the port.h needed to be cleaned up so that the tests continue working
a few more fixes (see diffs).

jtattermusch · 2019-10-07T12:32:24Z

Current failures from a local run
https://source.cloud.google.com/results/invocations/986ca05e-37c1-4cda-9686-755949594aea/targets

bazel --bazelrc=tools/remote_build/mac.bazelrc test //test/... --keep_going

jtattermusch · 2019-10-07T12:54:38Z

One problem to overcome #20494 (I now understand what's going on)

jtattermusch · 2019-10-17T14:50:49Z

The other problem is that with this hack:

grpc/include/grpc/impl/codegen/port_platform.h

Line 236 in a0ad408

#define GPR_PTHREAD_TLS 1

, on macos under bazel we're using GPR_PTHREAD_TLS instead of GPR_GCC_TLS, but that actually fixed our macos bazel but it breaks some of the tests
because the thread local storage in uninitialized. E.g.

Executing tests from //test/core/backoff:backoff_test
-----------------------------------------------------------------------------
D1017 10:13:21.109471000 4373829056 test_config.cc:384]                test slowdown factor: sanitizer=1, fixture=1, poller=1, total=1
[==========] Running 4 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 4 tests from BackOffTest
[ RUN      ] BackOffTest.ConstantBackOff
E1017 10:13:21.110358000 4373829056 tls_pthread.cc:26]                 assertion failed: 0 == pthread_setspecific(tls->key, (void*)value)

bazelbuild/bazel#4341

jtattermusch · 2019-10-17T15:10:39Z

New test run: https://source.cloud.google.com/results/invocations/47e7fdf1-05b8-4363-a08a-78ecdc9165a6

jtattermusch · 2019-10-24T07:22:54Z

Results so far: https://source.cloud.google.com/results/invocations/cf20b310-8718-427c-a5f5-a9d7de5daed6/targets

jtattermusch · 2019-10-25T13:06:02Z

https://source.cloud.google.com/results/invocations/e7938d61-8f53-4f1a-a638-2f7abbcfa6c3

jtattermusch · 2019-11-04T18:38:24Z

https://source.cloud.google.com/results/invocations/bdf17ac6-9bba-4b32-a7fc-21197c7fb935

jtattermusch · 2019-11-05T16:21:23Z

I included the changes from #20864.

jtattermusch · 2019-11-19T13:16:54Z

https://source.cloud.google.com/results/invocations/7c138a11-2490-4e7e-8523-b35f9106ecb5

jtattermusch · 2019-11-25T12:59:19Z

@veblush @rmstar this is ready for review.

An adhoc run with all the tests passing: https://source.cloud.google.com/results/invocations/5c6c4d70-d6a2-491e-adf0-6b9dcb9e7d27/targets I still might need to look into test flakes, but this is good enough for a start.

rmstar

lgtm for CFStream

rmstar · 2019-11-26T18:28:41Z

test/core/security/credentials_test.cc

+  bool restore_home_env = false;
+#if defined(GRPC_BAZEL_BUILD) && \
+    (defined(GPR_POSIX_ENV) || defined(GPR_LINUX_ENV))
+  // when running under bazel with locally, the HOME variable is not set


nit: bazel with locally -> bazel locally

jtattermusch · 2019-11-27T11:09:33Z

Known failures:
#21297
#20459
#21309

jtattermusch mentioned this pull request Oct 17, 2019

When building with bazel on a Mac, workaround bazelbuild/bazel#4341 #13929

Merged

jtattermusch force-pushed the bazel_test_on_mac branch 2 times, most recently from f8350b9 to fd4473a Compare October 23, 2019 13:04

jtattermusch force-pushed the bazel_test_on_mac branch from 6571a15 to 77e4292 Compare October 29, 2019 17:34

jtattermusch force-pushed the bazel_test_on_mac branch from e2c7eac to d338162 Compare November 19, 2019 12:22

jtattermusch force-pushed the bazel_test_on_mac branch from 274dd5a to 1143a8e Compare November 22, 2019 11:55

jtattermusch and others added 9 commits November 25, 2019 13:35

disable a few macos bazel tests

5d352de

introduce mac.bazelrc

5bb72e0

avoid thread local unitialized problem under GRPC_PTHREAD_TLS

78888d7

dont run resolver_component_tests_runner_invoker on mac

f427cac

WIP: Make core and C++ tests work with bazel on Mac OS

2526dfa

improve cfg files and sh script

7bdfac2

fix //test/core/security:credentials_test under local bazel run

04796c8

adjust port.h to fix parse_address_with_named_scope_id_test

2791791

make tcp_posix_test run when CFSTREAM is enabled

05012c2

jtattermusch force-pushed the bazel_test_on_mac branch from 5cc0b5b to 770f09c Compare November 25, 2019 12:38

clang format

eb137ea

jtattermusch force-pushed the bazel_test_on_mac branch from 770f09c to eb137ea Compare November 25, 2019 12:46

jtattermusch changed the title ~~WIP: Running bazel tests on mac~~ Start running bazel C/C++ tests on mac Nov 25, 2019

jtattermusch assigned rmstar and veblush Nov 25, 2019

jtattermusch added lang/c++ release notes: no Indicates if PR should not be in release notes labels Nov 25, 2019

jtattermusch marked this pull request as ready for review November 25, 2019 13:02

veblush approved these changes Nov 26, 2019

View reviewed changes

rmstar approved these changes Nov 26, 2019

View reviewed changes

fix type

13843be

jtattermusch merged commit aa40b1c into grpc:master Nov 27, 2019

jtattermusch mentioned this pull request Dec 9, 2019

Sockpair doesn't work on MacOS when build using bazel #20494

Closed

jtattermusch mentioned this pull request Jan 2, 2020

grpc Mac bazel build fails because of thread-local, but make passes bazelbuild/bazel#4341

Closed

lock bot locked as resolved and limited conversation to collaborators Feb 25, 2020

Conversation

jtattermusch commented Oct 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jtattermusch commented Oct 7, 2019

Uh oh!

jtattermusch commented Oct 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jtattermusch commented Oct 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jtattermusch commented Oct 17, 2019

Uh oh!

jtattermusch commented Oct 24, 2019

Uh oh!

jtattermusch commented Oct 25, 2019

Uh oh!

jtattermusch commented Nov 4, 2019

Uh oh!

jtattermusch commented Nov 5, 2019

Uh oh!

jtattermusch commented Nov 19, 2019

Uh oh!

jtattermusch commented Nov 25, 2019

Uh oh!

rmstar left a comment

Choose a reason for hiding this comment

Uh oh!

rmstar Nov 26, 2019

Choose a reason for hiding this comment

Uh oh!

jtattermusch commented Nov 27, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jtattermusch commented Oct 7, 2019 •

edited

Loading

jtattermusch commented Oct 7, 2019 •

edited

Loading

jtattermusch commented Oct 17, 2019 •

edited

Loading