Make async server use one CQ per server thread#2028
Merged
vjpai merged 1 commit intogrpc:masterfrom Jun 10, 2015
Merged
Conversation
Contributor
There was a problem hiding this comment.
So, I'm still enforcing the policy of no new range-based for's with the intention of eventually making this code fully gcc-4.4 compatible.
Member
Author
There was a problem hiding this comment.
I don't see a range based for here?
Contributor
|
Besides my one minor nit above, I'm satisfied with the code here. I would LGTM. |
Contributor
|
Sorry,my eyes glazed over when I was reviewing this too late. My fault. |
vjpai
added a commit
that referenced
this pull request
Jun 10, 2015
Make async server use one CQ per server thread
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminate chances of contention due to server implementation