PHP: fix zend_hash_str_del() segfault#20249
Merged
stanley-cheung merged 2 commits intogrpc:masterfrom Sep 24, 2019
Merged
Conversation
HannahShiSFB
changed the title
stanley-cheung
added
lang/php
release notes: no
stanley-cheung
changed the title
stanley-cheung
added
release notes: yes
stanley-cheung
approved these changes
Sep 24, 2019
This was referenced Sep 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
avoid calling php_grpc_zend_hash_del() at all in the constructor.
keys ("credentials", "force_new", "grpc_target_persist_bound") cannot del from hash table since php refers them somewhere else.
in php_grpc_read_args_array(), ignore 3 special keys, when copy info to args.
using args, instead of args_array, to construct a sha1 hash key
ps: #19970, #19248 can be reproduced using unit tests in any os+enable debug