Cache commonly used grpc-status mdelems#1993
Merged
dgquintas merged 6 commits intogrpc:masterfrom Jun 9, 2015
Merged
Conversation
src/core/surface/channel.h
Outdated
Contributor
There was a problem hiding this comment.
docstring while at it? :)
dgquintas
added a commit
that referenced
this pull request
Jun 9, 2015
Cache commonly used grpc-status mdelems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of our tail latency includes conversion of status id to a string, and then locking the metadata context table to look up said value in a hash table, and then ignoring the work we just did.
Instead, for commonly used status values, pre-create the entire status element, and just ref it when needed (which can be done without acquiring the lock).