Skip to content

Verify protobuf 3.9.1 with GRPC#19867

Closed
anandolee wants to merge 8 commits intogrpc:masterfrom
anandolee:201908061552
Closed

Verify protobuf 3.9.1 with GRPC#19867
anandolee wants to merge 8 commits intogrpc:masterfrom
anandolee:201908061552

Conversation

@anandolee
Copy link
Copy Markdown
Contributor

No description provided.

@thelinuxfoundation
Copy link
Copy Markdown

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@anandolee anandolee closed this Aug 6, 2019
@anandolee anandolee reopened this Aug 6, 2019
@anandolee
Copy link
Copy Markdown
Contributor Author

I have signed

@jtattermusch
Copy link
Copy Markdown
Contributor

@anandolee
Copy link
Copy Markdown
Contributor Author

anandolee commented Aug 9, 2019

Updated tools/distrib/python/grpcio_tools/protoc_lib_deps.py
Please let me know if still have other files missing

@jtattermusch
Copy link
Copy Markdown
Contributor

There are some bazel build issues, e.g.:

ERROR: /var/local/git/grpc/src/python/grpcio_reflection/grpc_reflection/v1alpha/BUILD.bazel:17:1: error loading package '@com_google_protobuf//': Unable to find package for @rules_proto//proto:defs.bzl: The repository '@rules_proto' could not be resolved. and referenced by '//src/python/grpcio_reflection/grpc_reflection/v1alpha:grpc_reflection'
ERROR: Analysis of target '//src/python/grpcio_reflection/grpc_reflection/v1alpha:grpc_reflection' failed; build aborted: error loading package '@com_google_protobuf//': Unable to find package for @rules_proto//proto:defs.bzl: The repository '@rules_proto' could not be resolved.

@gnossen might know more.

@jtattermusch
Copy link
Copy Markdown
Contributor

There's also a problem with indentation of dependencies.props vs dependencies.props.template (they don't match)

5c5
<     <GoogleProtobufVersion>3.9.1</GoogleProtobufVersion>
---
>   <GoogleProtobufVersion>3.9.1</GoogleProtobufVersion>
Traceback (most recent call last):
  File "tools/buildgen/generate_projects.py", line 100, in <module>
    assert 0 == os.system('diff %s %s' % (s, g)), s
AssertionError: ./src/csharp/build/dependencies.props

@anandolee
Copy link
Copy Markdown
Contributor Author

Updated dependencies.props.template and ObjC podspec files

@jtattermusch
Copy link
Copy Markdown
Contributor

@rafi-kamal we haven't finished this one the last time protobuf was released let's finish this off or close?

@rafi-kamal
Copy link
Copy Markdown
Contributor

I talked to @anandolee offline, let's close this issue and focus on integrating 3.10.0 instead.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants