PHP: Fix missing addref in channel::constructor()#19737
Merged
stanley-cheung merged 1 commit intogrpc:masterfrom Jul 26, 2019
Merged
PHP: Fix missing addref in channel::constructor()#19737stanley-cheung merged 1 commit intogrpc:masterfrom
stanley-cheung merged 1 commit intogrpc:masterfrom
Conversation
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
Collaborator
Author
|
CLA signed |
stanley-cheung
changed the title
stanley-cheung
added
lang/php
release notes: yes
stanley-cheung
approved these changes
Jul 24, 2019
HannahShiSFB
force-pushed
the
channelConstructorAddref
branch
from
5553745 to
9841ed0
Compare
Contributor
|
Verified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed segfault in channel::constructor() and added one unit test case.
Fixes #19721