Get rid of unused Version.csproj.include#19679
Merged
jtattermusch merged 1 commit intogrpc:masterfrom Jul 19, 2019
Merged
Conversation
jtattermusch
added
lang/C#
release notes: no
Contributor
Author
|
CC @anandolee |
jtattermusch
force-pushed
the
cleanup_version_csproj
branch
from
566e1e2 to
c767398
Compare
apolcyn
approved these changes
Jul 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In https://github.com/grpc/grpc/pull/18486/files,
Version.csproj.includewas replaced withdependencies.props, but it wasn't really removed and we ended up with a dead copy ofVersion.csproj.includewhich isn't used from anywhere (but it was actually updated by some PRs by accident, making it looks that Google.Protobuf dependency version was updated when it really wasn't).This PR removes the dead copy and makes dependencies.props up to date.