Made grpc_byte_buffer_reader able to decompress msgs.#1963
Made grpc_byte_buffer_reader able to decompress msgs.#1963ctiller merged 4 commits intogrpc:masterfrom
Conversation
|
I've also moved a number of function grpc_byte_buffer_* declarations from grpc.h to a more fitting byte_buffer.h. |
include/grpc/byte_buffer.h
Outdated
There was a problem hiding this comment.
I'm not sure I understand what this means.
There was a problem hiding this comment.
The meaning behind the comment was that a channel compressed by default would, when instructed, not compress certain messages, resulting in said messages having this BB_COMPRESSED_NONE type. This would signal that the message indeed came from a compressing source but that in this instance, the data isn't compressed. I wonder if this distinction is useful though.
Given your proposed change below, the redundancy between BB_SLICE_BUFFER and COMPRESSED_NONE is removed anyway.
|
Comments addressed. It evolved into a bit of a refactoring. Plenty of changed files, but most are just "dumb" renamings. PTAL. |
Made grpc_byte_buffer_reader able to decompress msgs.
3 participants
Part of #1795.