Adding C++ API and implementation for STS credentials:#19587
Merged
jboeuf merged 1 commit intogrpc:masterfrom Jul 10, 2019
Merged
Adding C++ API and implementation for STS credentials:#19587jboeuf merged 1 commit intogrpc:masterfrom
jboeuf merged 1 commit intogrpc:masterfrom
Conversation
Contributor
jboeuf
commented
Jul 8, 2019
jboeuf
commented
- marked as experimental.
- also changed the name of a field in the options struct.
jboeuf
added
lang/c++
area/security
release notes: no
Contributor
Author
|
Note, this is the follow up of #19032 which added the STS creds functionality in core and that was reviewed by @markdroth /cc @JimmyCYJ |
yang-g
approved these changes
Jul 9, 2019
src/cpp/client/secure_credentials.cc
Outdated
Contributor
Author
There was a problem hiding this comment.
Actually I don't need this one since it's already on the corresponding header.
src/cpp/client/secure_credentials.h
Outdated
yang-g
approved these changes
Jul 9, 2019
- marked as experimental. - also changed the name of a field in the options struct.
Contributor
Author
|
Thanks much for the quick reviews @yang-g and @jiangtaoli2016. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.