Fix the assertion of grpc_udp_server_add_port()#19574
Merged
nanahpang merged 1 commit intogrpc:masterfrom Jul 11, 2019
Merged
Conversation
nanahpang
added
lang/c++
release notes: no
nanahpang
reviewed
Jul 11, 2019
grpc_udp_server_add_port() can return port = -1 when going fail. @nanahpang also recommands discarding port = 0
legendtang
force-pushed
the
insufficientassert
branch
from
5fca397 to
8e4d14f
Compare
Contributor
Author
Sure. I’ve changed it to > 0 |
nanahpang
approved these changes
Jul 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grpc_udp_server_add_port() can return port = -1 when going fail.