Skip to content

Update protobuf version to 3.8.0#19182

Merged
jtattermusch merged 6 commits intomasterfrom
unknown repository
Jun 18, 2019
Merged

Update protobuf version to 3.8.0#19182
jtattermusch merged 6 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented May 29, 2019

No description provided.

@ghost ghost requested review from a11r, jtattermusch, nicolasnoble and vjpai as code owners May 29, 2019 23:51
@jtattermusch
Copy link
Copy Markdown
Contributor

jtattermusch commented Jun 3, 2019

I'm seeing a failing distribtest:
https://source.cloud.google.com/results/invocations/5d258356-c24f-4f4f-bf4c-92f14cd29cac/targets/github%2Fgrpc/tests

+ cd examples/cpp/helloworld
+ make
protoc -I ../../protos --cpp_out=. ../../protos/helloworld.proto
g++ -std=c++11 `pkg-config --cflags protobuf grpc`  -c -o helloworld.pb.o helloworld.pb.cc
protoc -I ../../protos --grpc_out=. --plugin=protoc-gen-grpc=`which grpc_cpp_plugin` ../../protos/helloworld.proto
g++ -std=c++11 `pkg-config --cflags protobuf grpc`  -c -o helloworld.grpc.pb.o helloworld.grpc.pb.cc
g++ -std=c++11 `pkg-config --cflags protobuf grpc`  -c -o greeter_client.o greeter_client.cc
g++ helloworld.pb.o helloworld.grpc.pb.o greeter_client.o -L/usr/local/lib `pkg-config --libs protobuf grpc++ grpc` -Wl,--no-as-needed -lgrpc++_reflection -Wl,--as-needed -ldl -o greeter_client
g++ -std=c++11 `pkg-config --cflags protobuf grpc`  -c -o greeter_server.o greeter_server.cc
g++ helloworld.pb.o helloworld.grpc.pb.o greeter_server.o -L/usr/local/lib `pkg-config --libs protobuf grpc++ grpc` -Wl,--no-as-needed -lgrpc++_reflection -Wl,--as-needed -ldl -o greeter_server
g++ -std=c++11 `pkg-config --cflags protobuf grpc`  -c -o greeter_async_client.o greeter_async_client.cc
g++ helloworld.pb.o helloworld.grpc.pb.o greeter_async_client.o -L/usr/local/lib `pkg-config --libs protobuf grpc++ grpc` -Wl,--no-as-needed -lgrpc++_reflection -Wl,--as-needed -ldl -o greeter_async_client
g++ -std=c++11 `pkg-config --cflags protobuf grpc`  -c -o greeter_async_client2.o greeter_async_client2.cc
g++ helloworld.pb.o helloworld.grpc.pb.o greeter_async_client2.o -L/usr/local/lib `pkg-config --libs protobuf grpc++ grpc` -Wl,--no-as-needed -lgrpc++_reflection -Wl,--as-needed -ldl -o greeter_async_client2
/usr/bin/ld: greeter_async_client2.o: undefined reference to symbol 'pthread_create@@GLIBC_2.2.5'
//lib/x86_64-linux-gnu/libpthread.so.0: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
make: *** [greeter_async_client2] Error 1
Makefile:51: recipe for target 'greeter_async_client2' failed

jtattermusch
jtattermusch reviewed Jun 3, 2019
View reviewed changes
jtattermusch
jtattermusch reviewed Jun 3, 2019
View reviewed changes
bazel/grpc_deps.bzl
url = "https://boringssl.googlesource.com/boringssl/+archive/afc30d43eef92979b05776ec0963c9cede5fb80f.tar.gz",
)

if "com_github_madler_zlib" not in native.existing_rules():
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch Jun 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why exactly is this change needed? It looks like you're only renaming the library. Is that because we need to use the same name that protobuf uses?

Copy link
Copy Markdown
Author

@ghost ghost Jun 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea. Because protobuf somehow expects @zlib//:zlib to be present, and I don't want to build zlib twice: https://github.com/protocolbuffers/protobuf/blob/master/BUILD#L22

@jtattermusch
Copy link
Copy Markdown
Contributor

jtattermusch commented Jun 3, 2019

This looks mostly good, but there's a few more things to fix (see other comments).

@ghost
Copy link
Copy Markdown
Author

ghost commented Jun 11, 2019

I'm seeing a failing distribtest:
https://source.cloud.google.com/results/invocations/5d258356-c24f-4f4f-bf4c-92f14cd29cac/targets/github%2Fgrpc/tests

+ cd examples/cpp/helloworld
+ make
protoc -I ../../protos --cpp_out=. ../../protos/helloworld.proto
g++ -std=c++11 `pkg-config --cflags protobuf grpc`  -c -o helloworld.pb.o helloworld.pb.cc
protoc -I ../../protos --grpc_out=. --plugin=protoc-gen-grpc=`which grpc_cpp_plugin` ../../protos/helloworld.proto
g++ -std=c++11 `pkg-config --cflags protobuf grpc`  -c -o helloworld.grpc.pb.o helloworld.grpc.pb.cc
g++ -std=c++11 `pkg-config --cflags protobuf grpc`  -c -o greeter_client.o greeter_client.cc
g++ helloworld.pb.o helloworld.grpc.pb.o greeter_client.o -L/usr/local/lib `pkg-config --libs protobuf grpc++ grpc` -Wl,--no-as-needed -lgrpc++_reflection -Wl,--as-needed -ldl -o greeter_client
g++ -std=c++11 `pkg-config --cflags protobuf grpc`  -c -o greeter_server.o greeter_server.cc
g++ helloworld.pb.o helloworld.grpc.pb.o greeter_server.o -L/usr/local/lib `pkg-config --libs protobuf grpc++ grpc` -Wl,--no-as-needed -lgrpc++_reflection -Wl,--as-needed -ldl -o greeter_server
g++ -std=c++11 `pkg-config --cflags protobuf grpc`  -c -o greeter_async_client.o greeter_async_client.cc
g++ helloworld.pb.o helloworld.grpc.pb.o greeter_async_client.o -L/usr/local/lib `pkg-config --libs protobuf grpc++ grpc` -Wl,--no-as-needed -lgrpc++_reflection -Wl,--as-needed -ldl -o greeter_async_client
g++ -std=c++11 `pkg-config --cflags protobuf grpc`  -c -o greeter_async_client2.o greeter_async_client2.cc
g++ helloworld.pb.o helloworld.grpc.pb.o greeter_async_client2.o -L/usr/local/lib `pkg-config --libs protobuf grpc++ grpc` -Wl,--no-as-needed -lgrpc++_reflection -Wl,--as-needed -ldl -o greeter_async_client2
/usr/bin/ld: greeter_async_client2.o: undefined reference to symbol 'pthread_create@@GLIBC_2.2.5'
//lib/x86_64-linux-gnu/libpthread.so.0: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
make: *** [greeter_async_client2] Error 1
Makefile:51: recipe for target 'greeter_async_client2' failed

Fixed.

@ghost
Copy link
Copy Markdown
Author

ghost commented Jun 14, 2019

Ping?

@jtattermusch jtattermusch added release notes: no Indicates if PR should not be in release notes lang/all wrapped languages labels Jun 18, 2019
@jtattermusch
Copy link
Copy Markdown
Contributor

jtattermusch commented Jun 18, 2019

Known failures:
#18416
#18608

jtattermusch
jtattermusch approved these changes Jun 18, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging this to make sure it gets included in 1.22.x release branch of gRPC.

@jtattermusch jtattermusch merged commit 4d33b5c into grpc:master Jun 18, 2019
@daviddrysdale daviddrysdale mentioned this pull request Jun 18, 2019
Closed
This was referenced Jun 20, 2019
Merged
Merged
@jtattermusch jtattermusch mentioned this pull request Jul 17, 2019
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Sep 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@a11r a11r Awaiting requested review from a11r

@nicolasnoble nicolasnoble Awaiting requested review from nicolasnoble

@vjpai vjpai Awaiting requested review from vjpai

Assignees

No one assigned

Labels

lang/all wrapped languages release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jtattermusch