Update jessie-backports URL#18530
Merged
murgatroid99 merged 5 commits intogrpc:masterfrom Mar 29, 2019
Merged
Conversation
murgatroid99
added
the
release notes: no
nicolasnoble
approved these changes
Mar 26, 2019
Contributor
|
Hopefully this will fix the issues we've seen in #18477. CC @jtattermusch and @jiangtaoli2016. |
Contributor
jtattermusch
left a comment
jtattermusch
left a comment
There was a problem hiding this comment.
LGTM, but updated docker images need to be pushed for tests to pass.
jtattermusch
approved these changes
Mar 27, 2019
Member
Author
|
I had to change a lot more files to get all of the updated docker files to actually build, so it would be good to check them again. |
Contributor
|
LGTM again. I checked the test failures and they seem to be mostly: |
This was referenced Mar 29, 2019
ejona86
added a commit
to ejona86/grpc
that referenced
this pull request
Apr 5, 2019
Jessie has a line that looks like this, now-a-days, so the regex is no longer matching: deb http://security.debian.org/debian-security jessie/updates main But because that line was changed, downloads are also working correctly out-of-the-box. The sed was originally added in grpc#18530.
Contributor
|
Does this need to be backported to v1.19.x to fix #18646? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update jessie-backports URL as described in this post.