Use GRPC_CLOSURE_SCHED instead of GRPC_CLOSURE_RUN in complete_closure_step#18491
Merged
yashykt merged 1 commit intogrpc:masterfrom Mar 27, 2019
Merged
Use GRPC_CLOSURE_SCHED instead of GRPC_CLOSURE_RUN in complete_closure_step#18491yashykt merged 1 commit intogrpc:masterfrom
yashykt merged 1 commit intogrpc:masterfrom
Conversation
yashykt
added
the
release notes: no
markdroth
approved these changes
Mar 25, 2019
Member
markdroth
left a comment
markdroth
left a comment
There was a problem hiding this comment.
Please make sure that this does not affect performance before merging.
Member
Author
|
Internal benchmark runs do not show any negative affect |
Member
Author
|
Thanks for reviewing! |
Member
Author
|
Macos failure looks infra related but kokoro is currently facing issues so cannot rerun. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use GRPC_CLOSURE_SCHED instead of GRPC_CLOSURE_RUN in complete_closure_step.
Doing this makes sure that we will be done executing code in the calling function before we run the closure.