Skip to content

Fix minor bug GRPC_TIMER_END before end of function#1833

Merged
dgquintas merged 1 commit intogrpc:masterfrom
zayoo:master
Jun 9, 2015
Merged

Fix minor bug GRPC_TIMER_END before end of function#1833
dgquintas merged 1 commit intogrpc:masterfrom
zayoo:master

Conversation

@zayoo
Copy link
Copy Markdown
Contributor

@zayoo zayoo commented May 29, 2015

GRPC_TIMER_END should be called at the end of function instead of GRPC_TIMER_BEGIN

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@zayoo
Copy link
Copy Markdown
Contributor Author

zayoo commented May 29, 2015

I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@dgquintas
Copy link
Copy Markdown
Contributor

Thanks @zayoo! I'll merge once Travis goes green (which it should, this change is a no-op for Travis).

@zayoo
Copy link
Copy Markdown
Contributor Author

zayoo commented Jun 1, 2015

I don't know why it caused a test case to fail. I am looking at the test case.

dgquintas added a commit that referenced this pull request Jun 9, 2015
Fix minor bug GRPC_TIMER_END before end of function
@dgquintas dgquintas merged commit a561ea6 into grpc:master Jun 9, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 31, 2019
@lock lock bot unassigned dgquintas Jan 31, 2019
@thelinuxfoundation
Copy link
Copy Markdown

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants