Allow trust anchor in gRPC ssl transport security#17868
Merged
jiangtaoli2016 merged 1 commit intogrpc:masterfrom Jan 30, 2019
Merged
Allow trust anchor in gRPC ssl transport security#17868jiangtaoli2016 merged 1 commit intogrpc:masterfrom
jiangtaoli2016 merged 1 commit intogrpc:masterfrom
Conversation
jiangtaoli2016
added
area/security
release notes: yes
Author
srini100
approved these changes
Jan 30, 2019
Contributor
srini100
left a comment
srini100
left a comment
There was a problem hiding this comment.
LGTM for adding the two flags.
Contributor
|
This should also resolve #17685 |
Author
|
Know failures: #17814 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow both local trust anchors and prefer local trust settings in gRPC SSL transport security. This aligns with modern OpenSSL setting and also addresses the inconsistent behavior between grpc core and grpc golang.