Skip to content

Use x64 tools on 64-bit Windows in Grpc.Tools (#17437 for master branch)#17524

Merged
jtattermusch merged 1 commit intogrpc:masterfrom
jtattermusch:64bit_windows_grpc_tools
Dec 18, 2018
Merged

Use x64 tools on 64-bit Windows in Grpc.Tools (#17437 for master branch)#17524
jtattermusch merged 1 commit intogrpc:masterfrom
jtattermusch:64bit_windows_grpc_tools

Conversation

@jtattermusch
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor Author

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@grpc-testing
Copy link
Copy Markdown

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,026,842      Total (=)      2,026,842

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,324,726      Total (<)     11,324,728

 No significant differences in binary sizes


@kkm000
Copy link
Copy Markdown
Contributor

kkm000 commented Dec 18, 2018

@jtattermusch, Thanks! So I'll close the other one?

@jtattermusch
Copy link
Copy Markdown
Contributor Author

Known failures:
#17526

@jtattermusch jtattermusch merged commit 70a4915 into grpc:master Dec 18, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Mar 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lang/C# release notes: yes Indicates if PR needs to be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No need to package 64-bit protoc and C# codegen for Windows

5 participants