Skip to content

Reverting #17378#17488

Merged
nicolasnoble merged 2 commits intogrpc:masterfrom
nicolasnoble:revert-windows-logs
Dec 14, 2018
Merged

Reverting #17378#17488
nicolasnoble merged 2 commits intogrpc:masterfrom
nicolasnoble:revert-windows-logs

Conversation

@nicolasnoble
Copy link
Copy Markdown
Contributor

@nicolasnoble nicolasnoble commented Dec 12, 2018

This is mainly to see if tests are passing again now. Tests have been failing weirdly since then. I haven't done a full bisect yet, but the failure seems very likely to be caused by this.

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 12, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 12, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,020,870      Total (=)      2,020,870

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,177,121      Total (<)     11,177,125

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2018 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,020,870      Total (=)      2,020,870

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,177,123      Total (>)     11,177,120

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2018 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,020,870      Total (=)      2,020,870

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,177,124      Total (<)     11,177,125

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2018 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,020,870      Total (=)      2,020,870

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,177,121      Total (<)     11,177,124

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2018 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,026,842      Total (=)      2,026,842

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,311,964      Total (<)     11,311,967

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2018 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,026,842      Total (=)      2,026,842

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,311,970      Total (>)     11,311,961

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2018 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,026,842      Total (=)      2,026,842

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,311,961      Total (<)     11,311,967

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 13, 2018 

[microbenchmarks] No significant performance differences

@nicolasnoble
Copy link
Copy Markdown
Contributor Author

nicolasnoble commented Dec 14, 2018

The Windows tests have systematically been passing properly, with none of the runaway issues we've been seeing elsewhere. Merging this one.

@jtattermusch there's an internal bug filed for this one.

@nicolasnoble nicolasnoble merged commit c542d44 into grpc:master Dec 14, 2018
@jtattermusch jtattermusch mentioned this pull request Dec 18, 2018
Closed
@jtattermusch jtattermusch mentioned this pull request Jan 2, 2019
Merged
@srini100 srini100 added the release notes: no Indicates if PR should not be in release notes label Jan 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@markdroth markdroth markdroth approved these changes

@jtattermusch jtattermusch Awaiting requested review from jtattermusch

Assignees

No one assigned

Labels

release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nicolasnoble @grpc-testing @markdroth @grpc-kokoro @srini100