Skip to content

Update urllib3 to avoid security vulnerability#17476

Merged
gnossen merged 1 commit intomasterfrom
update-urllib
Dec 12, 2018
Merged

Update urllib3 to avoid security vulnerability#17476
gnossen merged 1 commit intomasterfrom
update-urllib

Conversation

@gnossen
Copy link
Copy Markdown
Contributor

@gnossen gnossen commented Dec 12, 2018

This PR updates urllib3 to avoid CVE-2018-20060. This update process will be automatic after #17177 is resolved.

@gnossen gnossen added lang/Python area/security release notes: no Indicates if PR should not be in release notes labels Dec 12, 2018
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 12, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 12, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 12, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 12, 2018 

[trickle] No significant performance differences

@gnossen gnossen mentioned this pull request Dec 12, 2018
Merged
@gnossen gnossen added release notes: yes Indicates if PR needs to be in release notes and removed release notes: no Indicates if PR should not be in release notes labels Dec 12, 2018
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 12, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,020,870      Total (=)      2,020,870

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,177,126      Total (>)     11,177,125

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 12, 2018 

Corrupt JSON data (indicates timeout or crash): 
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10


[microbenchmarks] No significant performance differences

@gnossen
Copy link
Copy Markdown
Contributor Author

gnossen commented Dec 12, 2018

Infrastructure problem during setup for Interop Cloud-to-Cloud tests:

Entering 'packages/grpc-tools/deps/protobuf'
Submodule 'packages/grpc-tools/deps/protobuf' (https://github.com/protocolbuffers/protobuf) registered for path 'packages/grpc-tools/deps/protobuf'
Cloning into 'packages/grpc-tools/deps/protobuf'...
fatal: unable to access 'https://github.com/protocolbuffers/protobuf/';: gnutls_handshake() failed: Error in the pull function.
Clone of 'https://github.com/protocolbuffers/protobuf'; into submodule path 'packages/grpc-tools/deps/protobuf' failed

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 12, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,020,870      Total (=)      2,020,870

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,177,122      Total (>)     11,177,121

 No significant differences in binary sizes

@gnossen
Copy link
Copy Markdown
Contributor Author

gnossen commented Dec 12, 2018

Flake: #17463

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 12, 2018 

Corrupt JSON data (indicates timeout or crash): 
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10


[microbenchmarks] No significant performance differences

@gnossen gnossen merged commit 551a037 into master Dec 12, 2018
@gnossen gnossen deleted the update-urllib branch February 15, 2019 17:27
@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ericgribkoff ericgribkoff ericgribkoff approved these changes

@lidizheng lidizheng lidizheng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ericgribkoff ericgribkoff

@lidizheng lidizheng

Labels

area/security lang/Python release notes: yes Indicates if PR needs to be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gnossen @grpc-testing @ericgribkoff @lidizheng