Skip to content

Revert stripping manylinux1 binary wheels to fix bad checksum of .so file#17415

Merged
ericgribkoff merged 1 commit intogrpc:v1.17.xfrom
ericgribkoff:cython_strip_backport
Dec 6, 2018
Merged

Revert stripping manylinux1 binary wheels to fix bad checksum of .so file#17415
ericgribkoff merged 1 commit intogrpc:v1.17.xfrom
ericgribkoff:cython_strip_backport

Conversation

@ericgribkoff
Copy link
Copy Markdown
Contributor

Backport of #17412

This reverts commit be4b2db.

Appears to leave the incorrect hash in the wheel RECORD file, as in
grpc#17409
@grpc-testing
Copy link
Copy Markdown

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]



@ericgribkoff ericgribkoff added lang/Python release notes: no Indicates if PR should not be in release notes labels Dec 5, 2018
@grpc-testing
Copy link
Copy Markdown

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

Corrupt JSON data (indicates timeout or crash): 
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10


[microbenchmarks] No significant performance differences

@ericgribkoff ericgribkoff merged commit d5d6e21 into grpc:v1.17.x Dec 6, 2018
@srini100 srini100 changed the title Revert "Strip manylinux1 binary wheels" Revert stripping manylinux1 binary wheels to fix bad checksum of .so file Dec 6, 2018
@srini100 srini100 added release notes: yes Indicates if PR needs to be in release notes and removed release notes: no Indicates if PR should not be in release notes labels Dec 6, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lang/Python release notes: yes Indicates if PR needs to be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants