Skip to content

Revert "Strip manylinux1 binary wheels"#17412

Merged
ericgribkoff merged 1 commit intogrpc:masterfrom
ericgribkoff:revert_cython_strip
Dec 5, 2018
Merged

Revert "Strip manylinux1 binary wheels"#17412
ericgribkoff merged 1 commit intogrpc:masterfrom
ericgribkoff:revert_cython_strip

Conversation

@ericgribkoff
Copy link
Copy Markdown
Contributor

@ericgribkoff ericgribkoff commented Dec 5, 2018

This reverts commit be4b2db.

Appears to leave the incorrect hash in the wheel RECORD file, as in #17409

@ericgribkoff
Revert "Strip manylinux1 binary wheels"
4590fc5 
This reverts commit be4b2db.

Appears to leave the incorrect hash in the wheel RECORD file, as in
grpc#17409
@gnossen gnossen added release notes: yes Indicates if PR needs to be in release notes lang/Python labels Dec 5, 2018
@nicolasnoble
Copy link
Copy Markdown
Contributor

nicolasnoble commented Dec 5, 2018

You'll want to backport this to 1.17.

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 5, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 5, 2018 

[trickle] No significant performance differences

@gnossen
Copy link
Copy Markdown
Contributor

gnossen commented Dec 5, 2018

Ran into known unrelated failure: #17375

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 5, 2018 

Corrupt JSON data (indicates timeout or crash): 
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10


[microbenchmarks] No significant performance differences

@ericgribkoff ericgribkoff mentioned this pull request Dec 5, 2018
Merged
@ericgribkoff ericgribkoff merged commit eca8e79 into grpc:master Dec 5, 2018
@ericgribkoff ericgribkoff mentioned this pull request Dec 6, 2018
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gnossen gnossen gnossen approved these changes

+2 more reviewers

@nicolasnoble nicolasnoble nicolasnoble approved these changes

@lidizheng lidizheng lidizheng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lang/Python release notes: yes Indicates if PR needs to be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ericgribkoff @nicolasnoble @grpc-testing @gnossen @lidizheng