Skip to content

fix macos PR jobs on high-sierra workers (for v1.17.x)#17406

Merged
jtattermusch merged 1 commit intogrpc:v1.17.xfrom
jtattermusch:fix_pr_high_sierra_v1_17_x
Dec 5, 2018
Merged

fix macos PR jobs on high-sierra workers (for v1.17.x)#17406
jtattermusch merged 1 commit intogrpc:v1.17.xfrom
jtattermusch:fix_pr_high_sierra_v1_17_x

Conversation

@jtattermusch
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch commented Dec 5, 2018

Fix macos PR jobs in v1.17.x as well (backport of #17404).

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 5, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 5, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 5, 2018 

Corrupt JSON data (indicates timeout or crash): 
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10


[microbenchmarks] No significant performance differences

@muxi
Copy link
Copy Markdown
Contributor

muxi commented Dec 5, 2018

Why not update jq in the image?

@jtattermusch
Copy link
Copy Markdown
Contributor Author

jtattermusch commented Dec 5, 2018

@muxi we don't actually need to upgrade jq, but I'm doing that for consistency with sierra images.
Btw, updating the image is a lot of overhead and we can't even to do that ourselves (kokoro team need to do that).

@jtattermusch jtattermusch merged commit 25eb200 into grpc:v1.17.x Dec 5, 2018
@muxi
Copy link
Copy Markdown
Contributor

muxi commented Dec 5, 2018

Yea. I mean if this is something that users are consistently doing (like we are doing this for every mac task) we can probably poke Kokoro team to update it.

@srini100 srini100 added the release notes: no Indicates if PR should not be in release notes label Dec 6, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@muxi muxi muxi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@muxi muxi

Labels

release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jtattermusch @grpc-testing @muxi @srini100