Skip to content

Change xds plugin name to xds_experimental until it's ready for use.#17405

Merged
markdroth merged 1 commit intogrpc:v1.17.xfrom
markdroth:xds_experimental_v1.17.x
Dec 5, 2018
Merged

Change xds plugin name to xds_experimental until it's ready for use.#17405
markdroth merged 1 commit intogrpc:v1.17.xfrom
markdroth:xds_experimental_v1.17.x

Conversation

@markdroth
Copy link
Copy Markdown
Member

@markdroth markdroth commented Dec 5, 2018 •
edited
Loading

Same as #17392, but for the v1.17.x branch.

@markdroth markdroth added lang/core release notes: no Indicates if PR should not be in release notes labels Dec 5, 2018
@markdroth markdroth requested a review from apolcyn as a code owner December 5, 2018 16:13
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 5, 2018 

****************************************************************

libgrpc.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  +0.0%     +16 [None]       0  [ = ]

  +0.0%     +16 TOTAL        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 5, 2018 

[trickle] No significant performance differences

@srini100
Copy link
Copy Markdown
Contributor

srini100 commented Dec 5, 2018

Marked as blocker for next patch on v1.17.x branch.

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 5, 2018 

Corrupt JSON data (indicates timeout or crash): 
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10


[microbenchmarks] No significant performance differences

@markdroth markdroth merged commit 738dd38 into grpc:v1.17.x Dec 5, 2018
@markdroth markdroth deleted the xds_experimental_v1.17.x branch December 5, 2018 17:45
@srini100 srini100 added release notes: yes Indicates if PR needs to be in release notes and removed priority/P0/RELEASE BLOCKER release notes: no Indicates if PR should not be in release notes labels Dec 6, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vishalpowar vishalpowar Awaiting requested review from vishalpowar

@apolcyn apolcyn Awaiting requested review from apolcyn apolcyn is a code owner

1 more reviewer

@AspirinSJL AspirinSJL AspirinSJL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lang/core release notes: yes Indicates if PR needs to be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@markdroth @grpc-testing @srini100 @AspirinSJL