Skip to content

fix macos PR jobs on high-sierra workers#17404

Merged
jtattermusch merged 1 commit intogrpc:masterfrom
jtattermusch:fix_pr_high_sierra
Dec 5, 2018
Merged

fix macos PR jobs on high-sierra workers#17404
jtattermusch merged 1 commit intogrpc:masterfrom
jtattermusch:fix_pr_high_sierra

Conversation

@jtattermusch
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch commented Dec 5, 2018

Looks like macos high sierra workers already have jq installed, so PR jobs are failing with:

Error: jq 1.5_3 is already installed
To upgrade to 1.6, run `brew upgrade jq`

@jtattermusch jtattermusch added release notes: no Indicates if PR should not be in release notes lang/all wrapped languages labels Dec 5, 2018
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 5, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 5, 2018 

[trickle] No significant performance differences

@jtattermusch
Copy link
Copy Markdown
Contributor Author

jtattermusch commented Dec 5, 2018

Merging early for fix broken PR tests.

@jtattermusch jtattermusch mentioned this pull request Dec 5, 2018
Merged
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 5, 2018 

Corrupt JSON data (indicates timeout or crash): 
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10


[microbenchmarks] No significant performance differences

@jtattermusch jtattermusch merged commit 354d872 into grpc:master Dec 5, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@markdroth markdroth markdroth approved these changes

Assignees

No one assigned

Labels

lang/all wrapped languages release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtattermusch @grpc-testing @markdroth