Skip to content

Change xds plugin name to xds_experimental until it's ready for use.#17392

Merged
markdroth merged 1 commit intogrpc:masterfrom
markdroth:xds_experimental
Dec 5, 2018
Merged

Change xds plugin name to xds_experimental until it's ready for use.#17392
markdroth merged 1 commit intogrpc:masterfrom
markdroth:xds_experimental

Conversation

@markdroth
Copy link
Copy Markdown
Member

@markdroth markdroth commented Dec 4, 2018

This ensures that anyone using an older grpc build will not be affected when the resolver starts telling clients to use the xds policy.

@markdroth markdroth added lang/core release notes: no Indicates if PR should not be in release notes labels Dec 4, 2018
@markdroth markdroth requested a review from apolcyn as a code owner December 4, 2018 17:52
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 4, 2018 

****************************************************************

libgrpc.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  +0.0%     +16 [None]       0  [ = ]

  +0.0%     +16 TOTAL        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 4, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 4, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,019,735      Total (>)      2,019,718

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,154,116      Total (=)     11,154,116

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 4, 2018 

Corrupt JSON data (indicates timeout or crash): 
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10


[microbenchmarks] No significant performance differences

@markdroth markdroth mentioned this pull request Dec 5, 2018
Merged
@markdroth markdroth merged commit 9bd5b37 into grpc:master Dec 5, 2018
@markdroth markdroth deleted the xds_experimental branch December 5, 2018 17:46
@lock lock bot locked as resolved and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@apolcyn apolcyn Awaiting requested review from apolcyn

2 more reviewers

@AspirinSJL AspirinSJL AspirinSJL approved these changes

@vishalpowar vishalpowar vishalpowar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lang/core release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@markdroth @grpc-testing @AspirinSJL @vishalpowar