Skip to content

Fix bazel 0.20's deprecated workspace imports.#17363

Merged
nicolasnoble merged 3 commits intogrpc:masterfrom
nicolasnoble:fix-bazel-0.20
Dec 3, 2018
Merged

Fix bazel 0.20's deprecated workspace imports.#17363
nicolasnoble merged 3 commits intogrpc:masterfrom
nicolasnoble:fix-bazel-0.20

Conversation

@nicolasnoble
Copy link
Copy Markdown
Contributor

@nicolasnoble nicolasnoble commented Nov 30, 2018

Bazel 0.20 released today deprecated a few of the directives we were importing. This fixes that.

@nicolasnoble nicolasnoble added the release notes: no Indicates if PR should not be in release notes label Nov 30, 2018
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 30, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 30, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 30, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,020,410      Total (=)      2,020,410

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,174,077      Total (<)     11,174,081

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 30, 2018 

Corrupt JSON data (indicates timeout or crash): 
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10


[microbenchmarks] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 30, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 30, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 1, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,020,410      Total (=)      2,020,410

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,174,077      Total (<)     11,174,079

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Dec 1, 2018 

Corrupt JSON data (indicates timeout or crash): 
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10


[microbenchmarks] No significant performance differences

jtattermusch
jtattermusch approved these changes Dec 3, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nicolasnoble nicolasnoble merged commit f8696b5 into grpc:master Dec 3, 2018
@moriarty
Copy link
Copy Markdown

moriarty commented Dec 5, 2018

Could this get cherry-picked into a released version? 1.17.0

It would be nice to be able to continue using grpc from a tagged release with bazel 0.20.

This was referenced Dec 7, 2018
Closed
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@a11r a11r Awaiting requested review from a11r

@vjpai vjpai Awaiting requested review from vjpai

1 more reviewer

@jtattermusch jtattermusch jtattermusch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolasnoble @grpc-testing @moriarty @jtattermusch