Skip to content

basic tcp_trace support for windows#17355

Closed
jtattermusch wants to merge 1 commit intogrpc:masterfrom
jtattermusch:windows_tcp_trace
Closed

basic tcp_trace support for windows#17355
jtattermusch wants to merge 1 commit intogrpc:masterfrom
jtattermusch:windows_tcp_trace

Conversation

@jtattermusch
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch commented Nov 30, 2018

Currently printing read and write payloads only works on unix (implemented in tcp_posix.cc).
Adding this support to windows is useful for debugging and good for consistency.

@jtattermusch jtattermusch added lang/core release notes: yes Indicates if PR needs to be in release notes labels Nov 30, 2018
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 30, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 30, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 30, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,020,410      Total (=)      2,020,410

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,174,080      Total (<)     11,174,081

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 30, 2018 

Corrupt JSON data (indicates timeout or crash): 
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10


[microbenchmarks] No significant performance differences

@jtattermusch jtattermusch mentioned this pull request Dec 3, 2018
Closed
@jtattermusch
Copy link
Copy Markdown
Contributor Author

jtattermusch commented Dec 6, 2018

This has been already merged into v1.17.x as #17378 (and will be upmerged to master later).

@jtattermusch
Copy link
Copy Markdown
Contributor Author

jtattermusch commented Dec 6, 2018

This was upmerged to master as part of #17423

@lock lock bot locked as resolved and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@AspirinSJL AspirinSJL AspirinSJL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@AspirinSJL AspirinSJL

@nicolasnoble nicolasnoble

Labels

lang/core release notes: yes Indicates if PR needs to be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jtattermusch @grpc-testing @AspirinSJL @nicolasnoble