Skip to content

PHP: fix ZTS build#17325

Merged
stanley-cheung merged 1 commit intogrpc:v1.17.xfrom
stanley-cheung:php-fix-zts
Nov 28, 2018
Merged

PHP: fix ZTS build#17325
stanley-cheung merged 1 commit intogrpc:v1.17.xfrom
stanley-cheung:php-fix-zts

Conversation

@stanley-cheung
Copy link
Copy Markdown
Contributor

@stanley-cheung stanley-cheung commented Nov 28, 2018

There's an uncaught additional fix needed on top of #17314

@stanley-cheung stanley-cheung added lang/php release notes: no Indicates if PR should not be in release notes labels Nov 28, 2018
@stanley-cheung stanley-cheung mentioned this pull request Nov 28, 2018
Merged
@stanley-cheung stanley-cheung merged commit a4c9b80 into grpc:v1.17.x Nov 28, 2018
@stanley-cheung stanley-cheung deleted the php-fix-zts branch November 28, 2018 23:52
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 28, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,020,496      Total (=)      2,020,496

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,175,623      Total (<)     11,175,637

 No significant differences in binary sizes

@lock lock bot locked as resolved and limited conversation to collaborators Feb 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ZhouyihaiDing ZhouyihaiDing ZhouyihaiDing approved these changes

Assignees

No one assigned

Labels

lang/php release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stanley-cheung @grpc-testing @ZhouyihaiDing