Skip to content

Fix PHP ZTS build breakage#17314

Merged
stanley-cheung merged 1 commit intogrpc:v1.17.xfrom
stanley-cheung:php-fix-zts
Nov 28, 2018
Merged

Fix PHP ZTS build breakage#17314
stanley-cheung merged 1 commit intogrpc:v1.17.xfrom
stanley-cheung:php-fix-zts

Conversation

@stanley-cheung
Copy link
Copy Markdown
Contributor

@stanley-cheung stanley-cheung commented Nov 28, 2018

Fixes #17273

This needs to go as the next 1.17.0RC3

@stanley-cheung stanley-cheung added lang/php release notes: no Indicates if PR should not be in release notes labels Nov 28, 2018
@stanley-cheung stanley-cheung mentioned this pull request Nov 28, 2018
Merged
@stanley-cheung
Copy link
Copy Markdown
Contributor Author

stanley-cheung commented Nov 28, 2018

@srini100 FYI

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 28, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,020,496      Total (=)      2,020,496

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,175,630      Total (>)     11,175,627

 No significant differences in binary sizes

ZhouyihaiDing
ZhouyihaiDing approved these changes Nov 28, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@ZhouyihaiDing ZhouyihaiDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanley-cheung stanley-cheung merged commit 3337a34 into grpc:v1.17.x Nov 28, 2018
@stanley-cheung stanley-cheung deleted the php-fix-zts branch November 28, 2018 17:22
This was referenced Nov 28, 2018
Merged
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Feb 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ZhouyihaiDing ZhouyihaiDing ZhouyihaiDing approved these changes

Assignees

No one assigned

Labels

lang/php release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stanley-cheung @grpc-testing @ZhouyihaiDing