New core shutdown API by ctiller · Pull Request #1731 · grpc/grpc

ctiller · 2015-05-22T21:43:27Z

jtattermusch · 2015-05-22T22:55:41Z

Just saw the same error with code that doesn't include this change, so it's probably unrelated. Created a separate issue #1734 for this.

jtattermusch · 2015-05-22T23:04:43Z

Just checked the python travis failure and it looks like this is not a known flake.

ctiller · 2015-05-22T23:07:03Z

Yeah I need to check that

jtattermusch · 2015-05-22T23:08:25Z

Otherwise looks good.

nathanielmanistaatgoogle · 2015-05-22T23:10:59Z

Wow. (_c_test timed out.)

ctiller · 2015-05-22T23:17:30Z

Restarted the Python test. Trying to reproduce here.

ctiller · 2015-05-22T23:29:45Z

This will need more investigation (Tuesday latest).

…omplete

ctiller · 2015-06-10T14:49:50Z

Renamed.

Update Python for core server shutdown change

ctiller · 2015-06-11T23:28:17Z

@nicolasnoble - it's probably safe to start this review

@jtattermusch - can you re-integrate C# changes?

nicolasnoble · 2015-06-11T23:29:00Z

Aye aye.

On Thu, Jun 11, 2015 at 4:28 PM, Craig Tiller [email protected]
wrote:

@nicolasnoble https://github.com/nicolasnoble - it's probably safe to
start this review

@jtattermusch https://github.com/jtattermusch - can you re-integrate C#
changes?

—
Reply to this email directly or view it on GitHub
#1731 (comment).

nicolasnoble · 2015-06-12T00:52:05Z

src/core/surface/completion_queue.c

have an exit label here maybe and use goto from everywhere else instead of duplicating the exit logic ?

It's worthwhile. There are further changes in #1577, and I want someone to do a thorough rewrite of this module entirely soon to eliminate any event related allocations - so maybe leave it til then?

Yeah fair enough. I've started reading #1577.

nicolasnoble · 2015-06-12T01:15:30Z

Aside from that nit, I didn't spot anything out of whack, and that globally is LGTM.

ctiller · 2015-06-15T14:05:03Z

@soltanmm @jtattermusch - we'll likely need to work together a little today to resolve conflicts.

…plete-me

Fix upstream merge conflicts

+ all tests pass, - but there are a couple of workarounds - tests are flaky

Initial progress on ruby shutdown api migration

temporary hotfix before backup poller removal is done

…hotfix undo hotfix from #1731

ctiller · 2015-06-17T19:28:20Z

VERT!

New core shutdown API

dklempner and others added 2 commits May 22, 2015 13:44

Make pollset shutdown repeatedly kick until all threads have left poll.

a4fb700

Tweak completion queue to newly agreed upon rules

70730b4

googlebot added the cla: yes label May 22, 2015

ctiller assigned jtattermusch May 22, 2015

ctiller mentioned this pull request May 22, 2015

Make pollset shutdown repeatedly kick until all threads have left poll. #1730

Closed

ctiller added the priority/P0/RELEASE BLOCKER label May 22, 2015

ctiller assigned nicolasnoble and unassigned jtattermusch May 22, 2015

nicolasnoble added the disposition/DO NOT MERGE label May 22, 2015

ctiller and others added 9 commits May 22, 2015 21:29

Merge github.com:grpc/grpc into you-complete-me

640dfaf

Add debug

6f2d647

Add debug

b04f072

Allow destroy to be delayed instead of stalling

0b877ce

Merge github.com:grpc/grpc into you-complete-me

a882e74

Add comment

b9c6d2f

Remove debug

5d2766b

Add silent events to completion queue - to allow server shutdown to c…

916a500

…omplete

Merge github.com:grpc/grpc into you-complete-me

56618b9

ctiller mentioned this pull request May 26, 2015

Workaround: Prevent threads sitting in epoll forever #1749

Merged

ctiller removed the priority/P0/RELEASE BLOCKER label May 26, 2015

ctiller added 3 commits May 26, 2015 15:27

Cleanup

dc62772

Merge github.com:grpc/grpc into you-complete-me

9db8f1a

Work towards removing grpc_server_shutdown

ee945e8

soltanmm and others added 2 commits June 10, 2015 17:32

Update Python for core server shutdown change

38bb18f

Merge pull request #15 from soltanmm/ct-you-complete-me

5e84be5

Update Python for core server shutdown change

nicolasnoble reviewed Jun 12, 2015
View reviewed changes

soltanmm and others added 8 commits June 15, 2015 10:29

Merge branch 'master' of https://github.com/grpc/grpc into ct-you-com…

a3697b4

…plete-me

Merge pull request #19 from soltanmm/ct-you-complete-me

18b4b83

Fix upstream merge conflicts

Merge github.com:grpc/grpc into you-complete-me

48dd6bf

Ruby shutdown api migration

b1fa5d4

+ all tests pass, - but there are a couple of workarounds - tests are flaky

Merge pull request #16 from tbetbetbe/you-complete-me

d5229da

Initial progress on ruby shutdown api migration

Migrate new test to new api

9194426

Merge github.com:grpc/grpc into you-complete-me

1680b40

Fix Python compilation

44a1dd3

This was referenced Jun 17, 2015

Remove backup poller from GRPC core #1577

Merged

Properly register completion queues with server #2061

Closed

jtattermusch and others added 2 commits June 17, 2015 10:39

temporary hotfix before #1577 is in

c0e3a66

Merge pull request #20 from jtattermusch/you-complete-me-csharp-hotfix

8c95eab

temporary hotfix before backup poller removal is done

jtattermusch added a commit to jtattermusch/grpc that referenced this pull request Jun 17, 2015

undo hotfix from grpc#1731

797b875

ctiller referenced this pull request in ctiller/grpc Jun 17, 2015

Merge pull request #21 from jtattermusch/we-dont-need-no-backup-undo-…

4581586

…hotfix undo hotfix from #1731

ctiller removed the disposition/DO NOT MERGE label Jun 17, 2015

nicolasnoble added a commit that referenced this pull request Jun 17, 2015

Merge pull request #1731 from ctiller/you-complete-me

a93954f

New core shutdown API

nicolasnoble merged commit a93954f into grpc:master Jun 17, 2015

This was referenced Jun 22, 2015

Ruby flake: run with no connect_metadata should not receive metadata if the client times out #1760

Closed

Ruby: Segfault on Travis #2005

Closed

jtattermusch mentioned this pull request Sep 1, 2015

C#: Detected 1 client calls that weren't disposed properly #1734

Closed

lock bot locked as resolved and limited conversation to collaborators Jan 31, 2019

Conversation

ctiller commented May 22, 2015

Uh oh!

jtattermusch commented May 22, 2015

Uh oh!

jtattermusch commented May 22, 2015

Uh oh!

ctiller commented May 22, 2015

Uh oh!

jtattermusch commented May 22, 2015

Uh oh!

nathanielmanistaatgoogle commented May 22, 2015

Uh oh!

ctiller commented May 22, 2015

Uh oh!

ctiller commented May 22, 2015

Uh oh!

ctiller commented Jun 10, 2015

Uh oh!

ctiller commented Jun 11, 2015

Uh oh!

nicolasnoble commented Jun 11, 2015

Uh oh!

nicolasnoble Jun 12, 2015

Choose a reason for hiding this comment

Uh oh!

ctiller Jun 12, 2015

Choose a reason for hiding this comment

Uh oh!

nicolasnoble Jun 12, 2015

Choose a reason for hiding this comment

Uh oh!

nicolasnoble commented Jun 12, 2015

Uh oh!

ctiller commented Jun 15, 2015

Uh oh!

ctiller commented Jun 17, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants