Skip to content

Use 'preX' version number when pre-releasing gRPC-C++.podspec#17277

Merged
muxi merged 1 commit intogrpc:v1.17.xfrom
muxi:grpc-cpp-pod-version
Nov 21, 2018
Merged

Use 'preX' version number when pre-releasing gRPC-C++.podspec#17277
muxi merged 1 commit intogrpc:v1.17.xfrom
muxi:grpc-cpp-pod-version

Conversation

@muxi
Copy link
Copy Markdown
Contributor

@muxi muxi commented Nov 21, 2018 •
edited
Loading

ref: firebase/firebase-ios-sdk#2102

If we directly release another version, during pre-release some users that are flexible on the version of gRPC-C++ pod will depend on the pre-release version of other gRPC pods. This will stop such behavior.

@muxi muxi requested a review from srini100 November 21, 2018 21:54
@muxi muxi added the release notes: no Indicates if PR should not be in release notes label Nov 21, 2018
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 21, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

srini100
srini100 approved these changes Nov 21, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@srini100 srini100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 21, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 21, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,020,496      Total (=)      2,020,496

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,175,630      Total (>)     11,175,628

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 21, 2018 

Corrupt JSON data (indicates timeout or crash): 
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10


[microbenchmarks] No significant performance differences

@muxi
Copy link
Copy Markdown
Contributor Author

muxi commented Nov 21, 2018

Basic Tests MacOS [dbg] - #16429

@muxi muxi merged commit a4be444 into grpc:v1.17.x Nov 21, 2018
@muxi muxi deleted the grpc-cpp-pod-version branch November 21, 2018 23:20
@lock lock bot locked as resolved and limited conversation to collaborators Feb 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@srini100 srini100 srini100 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@srini100 srini100

Labels

lang/c++ platform/iOS release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@muxi @grpc-testing @srini100