Skip to content

Add C# distribtest for alpine linux#17272

Merged
jtattermusch merged 1 commit intogrpc:masterfrom
jtattermusch:csharp_alpine_fixes
Oct 1, 2019
Merged

Add C# distribtest for alpine linux#17272
jtattermusch merged 1 commit intogrpc:masterfrom
jtattermusch:csharp_alpine_fixes

Conversation

@jtattermusch
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch commented Nov 21, 2018 •
edited
Loading

Add alpine 3.9 C# distribtest - a workaround mentioned here #18428 (comment) is necessary, but at least it things work with it.

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 21, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 21, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 21, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,020,494      Total (=)      2,020,494

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,175,630      Total (<)     11,175,633

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 21, 2018 

Corrupt JSON data (indicates timeout or crash): 
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10


[microbenchmarks] No significant performance differences

@apolcyn apolcyn mentioned this pull request Nov 26, 2018
Merged
@stale
Copy link
Copy Markdown

stale bot commented Sep 4, 2019

This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 180 days. It will be closed automatically if no further update occurs in 1 day. Thank you for your contributions!

@jtattermusch
Copy link
Copy Markdown
Contributor Author

jtattermusch commented Sep 5, 2019

Let's leave this open.

@stale stale bot removed the disposition/stale label Sep 5, 2019
@jtattermusch
Copy link
Copy Markdown
Contributor Author

jtattermusch commented Sep 5, 2019 •
edited
Loading

This is blocked because as of now protoc binary cannot run on alpine linux.
Related bug: #18338
Also related: #18428

@jtattermusch jtattermusch changed the title WIP: C# distribtest for alpine linux Add C# distribtest for alpine linux Oct 1, 2019
@jtattermusch
Copy link
Copy Markdown
Contributor Author

jtattermusch commented Oct 1, 2019

Added a workaround that makes both protoc and grpc work fine on Alpine 3.9 - it's worth adding a test to avoid further regressions.

@jtattermusch jtattermusch added release notes: no Indicates if PR should not be in release notes lang/C# labels Oct 1, 2019
@jtattermusch
Copy link
Copy Markdown
Contributor Author

jtattermusch commented Oct 1, 2019 •
edited
Loading

Adhoc distribtest run: https://sponge.corp.google.com/invocation?id=51a25ff8-e1bb-467a-8efc-4f1e6326f131&searchFor=

https://sponge.corp.google.com/invocation?tab=Build+Log&id=796af2e2-e27e-42fc-99af-807eb4c3c025&searchFor=

@jtattermusch jtattermusch mentioned this pull request Oct 1, 2019
Closed
@jtattermusch
Copy link
Copy Markdown
Contributor Author

jtattermusch commented Oct 1, 2019

The C# distribtests are green:
https://source.cloud.google.com/results/invocations/1b7ff29a-d440-4fa8-9b20-b50bb607b9d0/targets/github%2Fgrpc/tests

@jtattermusch
Copy link
Copy Markdown
Contributor Author

jtattermusch commented Oct 1, 2019

Known failures:
#20425
#20421

@jtattermusch jtattermusch merged commit e70d858 into grpc:master Oct 1, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@apolcyn apolcyn apolcyn approved these changes

@nicolasnoble nicolasnoble Awaiting requested review from nicolasnoble

Assignees

@apolcyn apolcyn

Labels

lang/C# release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtattermusch @grpc-testing @apolcyn