Skip to content

Wrap pthread_atfork call#17262

Merged
stanley-cheung merged 1 commit intogrpc:v1.17.xfrom
stanley-cheung:php-windows-fix
Nov 21, 2018
Merged

Wrap pthread_atfork call#17262
stanley-cheung merged 1 commit intogrpc:v1.17.xfrom
stanley-cheung:php-windows-fix

Conversation

@stanley-cheung
Copy link
Copy Markdown
Contributor

@stanley-cheung stanley-cheung commented Nov 20, 2018

The PHP extension Windows build is breaking. This flag is only set in config.m4 and not config.w32.

@stanley-cheung stanley-cheung added the release notes: no Indicates if PR should not be in release notes label Nov 20, 2018
srini100
srini100 approved these changes Nov 20, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@srini100 srini100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 21, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,020,496      Total (=)      2,020,496

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,175,630      Total (>)     11,175,626

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 21, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,020,496      Total (=)      2,020,496

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,175,631      Total (<)     11,175,635

 No significant differences in binary sizes

@stanley-cheung stanley-cheung merged commit c46d9f8 into grpc:v1.17.x Nov 21, 2018
@stanley-cheung stanley-cheung deleted the php-windows-fix branch November 21, 2018 00:09
@stanley-cheung stanley-cheung mentioned this pull request Nov 21, 2018
Merged
srini100
srini100 reviewed Nov 21, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@srini100 srini100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please upmerge master.

@stanley-cheung stanley-cheung mentioned this pull request Nov 21, 2018
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Feb 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@srini100 srini100 srini100 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stanley-cheung @grpc-testing @srini100