Skip to content

Bump v1.17.x version to v1.17.0-pre1#17246

Merged
muxi merged 4 commits intogrpc:v1.17.xfrom
muxi:v1.17.x
Nov 20, 2018
Merged

Bump v1.17.x version to v1.17.0-pre1#17246
muxi merged 4 commits intogrpc:v1.17.xfrom
muxi:v1.17.x

Conversation

@muxi
Copy link
Copy Markdown
Contributor

@muxi muxi commented Nov 19, 2018 •
edited
Loading

Initial version bump for release

@muxi muxi added the release notes: no Indicates if PR should not be in release notes label Nov 19, 2018
@muxi muxi requested a review from srini100 November 19, 2018 23:34
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 19, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE                                    FILE SIZE
 ++++++++++++++ GROWING                      ++++++++++++++
  +0.0%     +28 [None]                           +20  +0.0%
  +4.3%      +4 src/cpp/common/version_cc.cc      +4  +4.3%
      +8.7%      +4 grpc::Version[abi:cxx11]          +4  +8.7%

  +0.0%     +32 TOTAL                            +24  +0.0%

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 19, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 20, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,020,495      Total (>)      2,020,494

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,175,624      Total (<)     11,175,628

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 20, 2018 

Corrupt JSON data (indicates timeout or crash): 
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10


[microbenchmarks] No significant performance differences

srini100
srini100 suggested changes Nov 20, 2018
View reviewed changes
BUILD Outdated
@@ -68,7 +68,7 @@ g_stands_for = "gizmo"

core_version = "7.0.0-dev"
Copy link
Copy Markdown
Contributor

@srini100 srini100 Nov 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we change the core version suffix too.

build.yaml Outdated
@@ -14,7 +14,7 @@ settings:
'#10': See the expand_version.py for all the quirks here
core_version: 7.0.0-dev
Copy link
Copy Markdown
Contributor

@srini100 srini100 Nov 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Core version suffix should change to pre1

srini100
srini100 approved these changes Nov 20, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@srini100 srini100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 20, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE                                    FILE SIZE
 ++++++++++++++ GROWING                      ++++++++++++++
  +0.0%     +28 [None]                           +20  +0.0%
  +4.3%      +4 src/cpp/common/version_cc.cc      +4  +4.3%
      +8.7%      +4 grpc::Version[abi:cxx11]          +4  +8.7%

  +0.0%     +32 TOTAL                            +24  +0.0%

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 20, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 20, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE                                    FILE SIZE
 ++++++++++++++ GROWING                      ++++++++++++++
  +0.0%     +28 [None]                           +20  +0.0%
  +4.3%      +4 src/cpp/common/version_cc.cc      +4  +4.3%
      +8.7%      +4 grpc::Version[abi:cxx11]          +4  +8.7%

  +0.0%     +32 TOTAL                            +24  +0.0%

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 20, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 20, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,020,495      Total (>)      2,020,494

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,175,627      Total (>)     11,175,621

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 20, 2018 

Corrupt JSON data (indicates timeout or crash): 
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10


[microbenchmarks] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 20, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,020,496      Total (>)      2,020,494

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,175,626      Total (<)     11,175,630

 No significant differences in binary sizes

@muxi muxi merged commit 53cfea5 into grpc:v1.17.x Nov 20, 2018
@muxi muxi deleted the v1.17.x branch November 20, 2018 02:08
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 20, 2018 

Corrupt JSON data (indicates timeout or crash): 
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10


[microbenchmarks] No significant performance differences

@muxi muxi restored the v1.17.x branch November 20, 2018 18:50
@lock lock bot locked as resolved and limited conversation to collaborators Feb 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@srini100 srini100 srini100 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@srini100 srini100

Labels

release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@muxi @grpc-testing @srini100